Fix #10198: Be robust against missing annotations #10212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 6f32b62, I made sure the compiler could survive parsing a Java classfile referring to annotations missing from the classpath, but we could still run into trouble when a Scala unpickled class does the same. Tweaking the Tasty unpickler to drop missing annotations would require always forcing the symbols of all annotations which I would rather avoid doing. Instead, we adopt the same solution as Scala 2 did in sbt/zinc#701 and special-case the single place where we force annotations of inherited members to ignore missing annotations.
|
Ping for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 6f32b62, I made sure the compiler could survive parsing a Java
classfile referring to annotations missing from the classpath, but we
could still run into trouble when a Scala unpickled class does the same.
Tweaking the Tasty unpickler to drop missing annotations would require
always forcing the symbols of all annotations which I would rather avoid
doing. Instead, we adopt the same solution as Scala 2 did in
sbt/zinc#701 and special-case the single place
where we force annotations of inherited members to ignore missing
annotations.